[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16c6e9c58e9a: [ASTMatchers] Fix child traversal over range-for loops (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(&CurrentDepth); +if (!match(*Node->getLoopVariable()) || !ma

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(&CurrentDepth); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) aaron.ballma

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire updated this revision to Diff 314654. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94031/new/ https://reviews.llvm.org/D94031 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp clang/unittests/ASTMatcher

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(&CurrentDepth); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) steveir

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(&CurrentDepth); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) aaron.ballma

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(&CurrentDepth); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) Should

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94031 Files: clang/lib/ASTMatchers/ASTMat