[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

2021-01-06 Thread Anastasia Stulova via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e874fc014be: [OpenCL] Add clang extension for variadic functions. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D94027?vs=314869&id=314964#to

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

2021-01-06 Thread Marco Antognini via Phabricator via cfe-commits
mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94027/new/ https://reviews.llvm.org/D94027 ___ cfe-commits ma

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

2021-01-06 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D94027#2481597 , @mantognini wrote: > LGTM, just one question: I see in the other review you updated > clang/test/SemaOpenCL/extension-version.cl. Do you need to do the same here? Good spot! Thanks! CHANGES SINCE LAST ACTI

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

2021-01-06 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 314869. Anastasia added a comment. Added missing testing in extension-version.cl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94027/new/ https://reviews.llvm.org/D94027 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/OpenC

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

2021-01-06 Thread Marco Antognini via Phabricator via cfe-commits
mantognini added a comment. LGTM, just one question: I see in the other review you updated clang/test/SemaOpenCL/extension-version.cl. Do you need to do the same here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94027/new/ https://reviews.llvm.org/D94027