[PATCH] D93988: [ASTMatchers] Make tests explicit about mode-dependence

aaron.ballman added a comment. In D93988#2477961 , @steveire wrote: > In D93988#2477602 , @aaron.ballman > wrote: > >> Could you give me a bit more background about why you want to make this >> change? > > This ch

[PATCH] D93988: [ASTMatchers] Make tests explicit about mode-dependence

steveire added a comment. In D93988#2477602 , @aaron.ballman wrote: > Could you give me a bit more background about why you want to make this > change? This change makes it explicit so that we can see which tests work in only one mode, and if we want t

[PATCH] D93988: [ASTMatchers] Make tests explicit about mode-dependence

aaron.ballman added a comment. Could you give me a bit more background about why you want to make this change? There are tests which I would expect to match in any traversal mode (e.g., `EXPECT_TRUE(matches("class X {};", traverse(TK_AsIs, HasClassX)));`) so there's a part of me that wonders if

[PATCH] D93988: [ASTMatchers] Make tests explicit about mode-dependence

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93988 Files: clang/unittests/ASTMatchers/