[PATCH] D93743: [NewPM] Run ObjC ARC passes

This revision was automatically updated to reflect the committed changes. Closed by commit rG756dd707668c: [NewPM] Run ObjC ARC passes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93743/new/ https://reviews.llvm.org/D93743

[PATCH] D93743: [NewPM] Run ObjC ARC passes

ahatanak added a comment. OK, I see. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93743/new/ https://reviews.llvm.org/D93743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D93743: [NewPM] Run ObjC ARC passes

aeubanks added a comment. In D93743#2487987 , @ahatanak wrote: > LGTM. ARC contract pass isn't being run by the NPM, but you are going to > change that in the future, I guess? Looks like that's part of the codegen pipeline and not the optimization pipel

[PATCH] D93743: [NewPM] Run ObjC ARC passes

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM. ARC contract pass isn't being run by the NPM, but you are going to change that in the future, I guess? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D93743: [NewPM] Run ObjC ARC passes

aeubanks added a comment. In D93743#2485876 , @ahatanak wrote: > Is this change safe considering calls to `EP.get()` can add function > declarations to the module as you mentioned in > https://reviews.llvm.org/D86178? It's definitely safe right now sinc

[PATCH] D93743: [NewPM] Run ObjC ARC passes

ahatanak added a comment. Is this change safe considering calls to `EP.get()` can add function declarations to the module as you mentioned in https://reviews.llvm.org/D86178? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93743/new/ https://reviews

[PATCH] D93743: [NewPM] Run ObjC ARC passes

asbirlea added a comment. The changes LGTM, but I'd rather defer final review to ahatanak@. It would be good to have some testing but it could be addressed in a separate patch, potentially by folks more familiar with the ObjCARC passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D93743: [NewPM] Run ObjC ARC passes

aeubanks added a comment. I couldn't find any existing tests that these passes run under the legacy PM. Perhaps checking the output of -debug-pass-manager is enough for a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93743/new/ https://revie

[PATCH] D93743: [NewPM] Run ObjC ARC passes

aeubanks created this revision. aeubanks added reviewers: ahatanak, ychen. Herald added a subscriber: hiraditya. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Match the legacy PM in running various ObjC ARC pass