[PATCH] D93683: [clangd] Do not take stale definition from the static index.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2522fa053b62: [clangd] Do not take stale definition from the static index. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93683/new/ h

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX marked an inline comment as done. ArcsinX added a comment. In D93683#2469584 , @sammccall wrote: > In D93683#2469553 , @ArcsinX wrote: > >> In D93683#2468842 , @sammc

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX updated this revision to Diff 313504. ArcsinX added a comment. Add comment. Fix possible `MergeIndexTest.LookupRemovedDefinition` test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93683/new/ https://reviews.llvm.org/D93683 Files:

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

sammccall added a comment. In D93683#2469553 , @ArcsinX wrote: > In D93683#2468842 , @sammccall wrote: > >> I'm not 100% sure this bug would block adding the equivalent change for >> `fuzzyFind` though - it'll affe

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX added a comment. In D93683#2468842 , @sammccall wrote: > I'm not 100% sure this bug would block adding the equivalent change for > `fuzzyFind` though - it'll affect documentSymbol but not code-completion IIUC > (because of the workaround I mentio

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D93683#2467631 , @ArcsinX wrote: > I also want to propose the similar patch for fuzzyFind() (as a part of this > patch or a separate one), but

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX updated this revision to Diff 313320. ArcsinX added a comment. - Simplify test. - Revert PreambleSymbols.update() first argument change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93683/new/ https://reviews.llvm.org/D93683 Files: clan

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX added reviewers: sammccall, kadircet. ArcsinX added a comment. I also want to propose the similar patch for fuzzyFind() (as a part of this patch or a separate one), but I faced the following problem: `Test.cpp` #define FOO 1 This example creates empty dynamic index for main file symb

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is follow up to D93393 . Without th