This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc6ea4d5b2c00: [clang][cli] Implement ContainsN Google Test
matcher (authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.org/D
Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.
lgtm.
We don't really have anywhere specific to put extra matchers, and we don't want
to add stuff to the actual gtest folder so it's easy to merge updates. So this
is fine.
Repositor
jansvoboda11 added inline comments.
Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:55
+
+MATCHER_P2(ContainsN, InnerMatcher, N,
+ describeContainsN(InnerMatcher, N, negation)) {
I'm not sure where custom Google Test matchers go. I guess
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This allows us to verify that we don't emit options multiple times.
In most cases, that w
