This revision was automatically updated to reflect the committed changes.
Closed by commit rG2a29ce303451: [hip] Fix HIP version parsing. (authored by
hliao).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93587/new/
https://reviews.llvm.org/D93587
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM overall.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:92
+// Parse and extract version numbers from `.hipVersion`. Return `true` if
+// the parsing fails.
+bool RocmInst
hliao updated this revision to Diff 314941.
hliao marked an inline comment as done.
hliao added a comment.
Revise following reviewers' comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93587/new/
https://reviews.llvm.org/D93587
Files:
clan
hliao marked an inline comment as done.
hliao added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:97
for (auto Part : VersionParts) {
auto Splits = Part.split('=');
+if (Splits.first == "HIP_VERSION_MAJOR") {
tra wrote:
> `Part.t
yaxunl added a comment.
Pls address Artem's comments. LGTM otherwise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93587/new/
https://reviews.llvm.org/D93587
___
cfe-commits mailing list
cfe-commits@lis
tra added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:91
-void RocmInstallationDetector::ParseHIPVersionFile(llvm::StringRef V) {
+bool RocmInstallationDetector::parseHIPVersionFile(llvm::StringRef V) {
SmallVector VersionParts;
A com
hliao added a comment.
PING
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93587/new/
https://reviews.llvm.org/D93587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
hliao created this revision.
hliao added reviewers: yaxunl, tra.
Herald added subscribers: kerbowa, nhaehnle, jvesely.
hliao requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
- Need trimming before parsing major or minor version numbers. This
