[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGd38973aa4d6a: [clang][AVR] Improve avr-ld command line options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D93579?vs=318881&id=321035#toc Repository: rG LLVM Github Mon

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 reopened this revision. benshi001 added a comment. This revision is now accepted and ready to land. It still cases many build failures, due to not enough test. I will redo it with a full test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 added a comment. committed as https://github.com/llvm/llvm-project/commit/89a5147e5a0c2e886cdf7ffa34799c069d825940 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 ___ cfe-commits mailing lis

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 ___ cfe-commits mailing list cfe-commits@

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 marked an inline comment as done. benshi001 added a comment. In D93579#2518307 , @MaskRay wrote: > If you remove your system GCC avr, does the test still work? This is the > criteria whether the patch is acceptable. Yes. The "make check-clang-d

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 updated this revision to Diff 318881. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/bin/avr-ld clang/test/Driver/Inputs/basic_avr_tree/lib/avr/lib

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

MaskRay added inline comments. Comment at: clang/test/Driver/avr-ld.c:46 + +int main() { return 0; } You can entirely delete the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 ___

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

MaskRay added a comment. If you remove your system GCC avr, does the test still work? This is the criteria whether the patch is acceptable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 ___ cfe-comm

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 updated this revision to Diff 318821. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/bin/avr-ld clang/test/Driver/Inputs/basic_avr_tree/lib/avr/lib

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:37 } MCUInfo[] = { {"at90s1200", "", "avr1"}, {"attiny11", "", "avr1"}, This may c

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

dylanmckay accepted this revision. dylanmckay added a comment. This revision is now accepted and ready to land. Great patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D93579 _

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93579