[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93446/new/ https://reviews.llvm.org/D93446 _

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:1 +#if defined(BUILTIN) && !defined(RISCVV_BUILTIN) +#define RISCVV_BUILTIN(ID, TYPE, ATTRS) BUILTIN(ID, TYPE, ATTRS) Need copyright header Comment at:

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

Jim added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:89 +#define BUILTIN(ID, TYPE, ATTRS) \ + {#ID, TYPE, ATTRS, nullptr, ALL_LANGUAGES, nullptr}, +#include "clang/Basic/BuiltinsRISCV.def" Should

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11127 +def err_riscvv_builtin_not_useable : Error< + "builtin requires 'V' extension support to be enabled">; } // end of sema component. Jim wrote: > Add blank line.

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

Jim added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:89 +#define BUILTIN(ID, TYPE, ATTRS) \ + {"__builtin_rvv_" #ID, TYPE, ATTRS, nullptr, ALL_LANGUAGES, nullptr}, +#include "clang/Basic/BuiltinsRISCV.def" --

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:89 +#define BUILTIN(ID, TYPE, ATTRS) \ + {"__builtin_rvv_" #ID, TYPE, ATTRS, nullptr, ALL_LANGUAGES, nullptr}, +#include "clang/Basic/BuiltinsRISCV.de

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

khchen added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:89 +#define BUILTIN(ID, TYPE, ATTRS) \ + {"__builtin_rvv_" #ID, TYPE, ATTRS, nullptr, ALL_LANGUAGES, nullptr}, +#include "clang/Basic/BuiltinsRISCV.def" ---

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

Jim added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11127 +def err_riscvv_builtin_not_useable : Error< + "builtin requires 'V' extension support to be enabled">; } // end of sema component. Add blank line. Is it "err_riscvv_

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

jrtc27 added inline comments. Comment at: clang/test/CodeGen/RISCV/vadd.c:22 +{ +return __builtin_rvv_vadd_vv_i8m1_vl(arg_0, arg_1, arg_2); +} Jim wrote: > Is it necessary with prefix "__builtin_"? > Refer to > https://github.com/riscv/rvv-intrinsic-doc/blob

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

Jim added inline comments. Comment at: clang/test/CodeGen/RISCV/vadd.c:22 +{ +return __builtin_rvv_vadd_vv_i8m1_vl(arg_0, arg_1, arg_2); +} Is it necessary with prefix "__builtin_"? Refer to https://github.com/riscv/rvv-intrinsic-doc/blob/master/rvv_intrinsi

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

HsiangKai added a comment. D95016 focuses on the Clang RVV builtin generator and it depends on this commit. I know it is clumsy to list the combinations for vadd plainly, but it is a simple way to demonstrate how to add RVV builtins in Clang. Could we accept th

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

HsiangKai added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:194 HasV = true; -else if (Feature == "+experimental-zfh") + HasRISCVVTypes = true; +} else if (Feature == "+experimental-zfh") khchen wrote: > HasRISCVVTypes is an

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

khchen added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:194 HasV = true; -else if (Feature == "+experimental-zfh") + HasRISCVVTypes = true; +} else if (Feature == "+experimental-zfh") HasRISCVVTypes is an undefined variable

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17569 + // The order of intrinsic operands is (maskedoff, op1, op2, mask, vl). + SmallVector ShuffleOps(Ops.size()); + ShuffleOps[0] = Ops[1]; I think this whole sequen