[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. Thanks for the commits, Aaron. If you don't mind I have a short question: both commits don't seem to list the test cases, have they not been committed at all or are they filtered out in github and/or phabricator? Did I mess something up? CHANGES SINCE LAST ACTION htt

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 348471575d9c24bbfb124ca5eac1589de075da88 , thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. Yes, I was gonna ask somebody else but if you have time, committing this one and https://reviews.llvm.org/D94478 would be nice CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman added a comment. In D93375#2493480 , @tbaeder wrote: > And thank you for reviewing my patches :) Happy to help! Btw, do you need someone to commit them on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. And thank you for reviewing my patches :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 ___ cfe-c

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder updated this revision to Diff 316118. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 Files: clang/include/clang/Driver/Options.td clang/test/Driver/ansi.c Index: clang/test/Driver/ansi.c =

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder updated this revision to Diff 316115. tbaeder added a comment. Okay, I've added a test and made sure it fails before and succeeds after this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 Files: clang/include/clang/Driver/Opti

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman added a comment. In D93375#2486165 , @tbaeder wrote: > That sounds good but it's different to what this patch is trying to > accomplish, isn't it? -ansi already doesn't get passed to the linker. > E.g. with clang 10.0.1 without this patch: >

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. That sounds good but it's different to what this patch is trying to accomplish, isn't it? -ansi already doesn't get passed to the linker. E.g. with clang 10.0.1 without this patch: ~ ❯ clang test.o -o test -ansi -### clang version 10.0.1 (Fedora 10.0.1-3.fc32) Targ

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman added a comment. In D93375#2479303 , @tbaeder wrote: > I guess I could add a test for the example I posted, but I'm not sure of how > much value that is. Or do you mean a test case that -ansi and -std=c89 behave > the same in every situatio

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. I guess I could add a test for the example I posted, but I'm not sure of how much value that is. Or do you mean a test case that -ansi and -std=c89 behave the same in every situation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llv

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

aaron.ballman added a comment. This seems reasonable to me, but I wonder if there's a way we can add test coverage for the change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/ https://reviews.llvm.org/D93375 ___ cfe-commits maili

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder updated this revision to Diff 313872. tbaeder added reviewers: jansvoboda11, thakis, Bigcheese. tbaeder added a comment. Rebased on lastest main branch and added a few more reviewers from git blame'ing the Options.td file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder created this revision. tbaeder added a reviewer: dang. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -ansi is documented as being the "same as -std=c89", but there are differences when passing it to a link: clang -c te