This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe5cdb6c56edf: [flang][driver] Add support for `-c` and
`-emit-obj` (authored by awarzynski).
Changed prior to commit:
https://reviews.llvm.org/D93
SouraVX accepted this revision.
SouraVX added a comment.
LGTM! - Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93301/new/
https://reviews.llvm.org/D93301
___
cfe-commits mailing list
cfe-commits@
clementval accepted this revision.
clementval added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93301/new/
https://reviews.llvm.org/D93301
_
awarzynski added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93301/new/
https://reviews.llvm.org/D93301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
awarzynski updated this revision to Diff 312457.
awarzynski added a comment.
Address PR comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93301/new/
https://reviews.llvm.org/D93301
Files:
clang/include/clang/Driver/Options.td
clang/lib/Dr
awarzynski marked an inline comment as done.
awarzynski added a comment.
@clementval & @SouraVX - thank you for your comments! I will upload an updated
version shortly.
Comment at: clang/include/clang/Driver/Options.td:4329
HelpText<"Generate machine code, but discard outpu
SouraVX added a comment.
Thanks! for the patch, some minor comments inlined. Rest LGTM. Let others also
have a look.
Comment at: clang/include/clang/Driver/Options.td:4329
HelpText<"Generate machine code, but discard output">;
-def emit_obj : Flag<["-"], "emit-obj">,
- Hel
clementval added inline comments.
Comment at: clang/include/clang/Driver/Options.td:4629
-} // let Flags = [CC1Option]
+} // let Flags = [CC1Option, NoDriverOption]
+
Is it intended to modify the SYCL options?
Comment at: flang/lib/Frontend/
awarzynski added a comment.
@dang , I would appreciate if you could take a look at the diff in Options.td -
you introduced the most recent changes there: https://reviews.llvm.org/D82574.
I got a bit confused with the nested `let` statements there. I couldn't find a
better way of marking `-emit-
awarzynski created this revision.
Herald added a reviewer: sscalpone.
Herald added a subscriber: dang.
awarzynski requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch adds a frontend action for emitting object files. While Flang
does
10 matches
Mail list logo