This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3d89b3cbec23: [CSSPGO] Introducing distribution factor for
pseudo probe. (authored by hoy).
Changed prior to commit:
https://reviews.llvm.org/D932
hoy updated this revision to Diff 320844.
hoy added a comment.
Rebasing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93264/new/
https://reviews.llvm.org/D93264
Files:
clang/test/CodeGen/pseudo-probe-emit.c
llvm/include/llvm/IR/IntrinsicInst.
hoy updated this revision to Diff 320822.
hoy added a comment.
Rebasing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93264/new/
https://reviews.llvm.org/D93264
Files:
clang/test/CodeGen/pseudo-probe-emit.c
llvm/include/llvm/IR/IntrinsicInst.
hoy updated this revision to Diff 317726.
hoy marked an inline comment as done.
hoy added a comment.
Addressing Wei's feedbacks.
Also prorating indirect callsite target count annotation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93264/new/
htt
wmi accepted this revision.
wmi added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:363
const FunctionSamples *CalleeSamples;
uint64_t CallsiteCount;
+ // Call site distribution factor to p
hoy added inline comments.
Comment at: llvm/include/llvm/IR/PseudoProbe.h:41
// [18:3] - probe id
- // [25:19] - reserved
+ // [25:19] - probe distribution factor
// [28:26] - probe type, see PseudoProbeType
wmi wrote:
> hoy wrote:
> > wmi wrote:
> >
wmi added inline comments.
Comment at: llvm/include/llvm/IR/PseudoProbe.h:41
// [18:3] - probe id
- // [25:19] - reserved
+ // [25:19] - probe distribution factor
// [28:26] - probe type, see PseudoProbeType
hoy wrote:
> wmi wrote:
> > hoy wrote:
> >
hoy added inline comments.
Comment at: llvm/include/llvm/IR/PseudoProbe.h:41
// [18:3] - probe id
- // [25:19] - reserved
+ // [25:19] - probe distribution factor
// [28:26] - probe type, see PseudoProbeType
wmi wrote:
> hoy wrote:
> > wmi wrote:
> >
wmi added inline comments.
Comment at: llvm/include/llvm/IR/PseudoProbe.h:41
// [18:3] - probe id
- // [25:19] - reserved
+ // [25:19] - probe distribution factor
// [28:26] - probe type, see PseudoProbeType
hoy wrote:
> wmi wrote:
> > hoy wrote:
> >
hoy added inline comments.
Comment at: llvm/include/llvm/IR/PseudoProbe.h:41
// [18:3] - probe id
- // [25:19] - reserved
+ // [25:19] - probe distribution factor
// [28:26] - probe type, see PseudoProbeType
wmi wrote:
> hoy wrote:
> > hoy wrote:
> >
wmi added inline comments.
Comment at: llvm/include/llvm/IR/PseudoProbe.h:41
// [18:3] - probe id
- // [25:19] - reserved
+ // [25:19] - probe distribution factor
// [28:26] - probe type, see PseudoProbeType
hoy wrote:
> hoy wrote:
> > wmi wrote:
> >
hoy updated this revision to Diff 316567.
hoy added a comment.
Adding support in the priority-based inliner.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93264/new/
https://reviews.llvm.org/D93264
Files:
clang/test/CodeGen/pseudo-probe-emit.c
hoy added inline comments.
Comment at: llvm/include/llvm/IR/PseudoProbe.h:41
// [18:3] - probe id
- // [25:19] - reserved
+ // [25:19] - probe distribution factor
// [28:26] - probe type, see PseudoProbeType
hoy wrote:
> wmi wrote:
> > The bits in dis
hoy added inline comments.
Comment at: llvm/include/llvm/IR/PseudoProbe.h:41
// [18:3] - probe id
- // [25:19] - reserved
+ // [25:19] - probe distribution factor
// [28:26] - probe type, see PseudoProbeType
wmi wrote:
> The bits in discriminator is a
wmi added inline comments.
Comment at: llvm/include/llvm/IR/PseudoProbe.h:41
// [18:3] - probe id
- // [25:19] - reserved
+ // [25:19] - probe distribution factor
// [28:26] - probe type, see PseudoProbeType
The bits in discriminator is a scare resour
hoy updated this revision to Diff 312339.
hoy added a comment.
Rebasing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93264/new/
https://reviews.llvm.org/D93264
Files:
clang/test/CodeGen/pseudo-probe-emit.c
llvm/include/llvm/IR/IntrinsicInst.
hoy created this revision.
Herald added subscribers: dexonsmith, wenlei, hiraditya.
hoy requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, jdoerfert.
Herald added projects: clang, LLVM.
Sample re-annotation is required in LTO time to achieve a reasonable
post-
17 matches
Mail list logo
