[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e3071007b4c: [analyzer] Introduce MacroExpansionContext to libAnalysis (authored by steakhal, committed by Balazs Benics ). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

steakhal marked 4 inline comments as done. steakhal added a comment. Thank you @Szelethus for taking the time to review this. This time I marked the inline comments done where it was applicable :) I'm gonna investigate some of your comments and if everything goes well I'm planning to commit this

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

Szelethus added inline comments. Comment at: clang/include/clang/Analysis/MacroExpansionContext.h:105 + using MacroExpansionText = SmallString<40>; + using ExpansionMap = llvm::DenseMap; + using ExpansionRangeMap = llvm::DenseMap; Hmm, I'm by no means an exper

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

Szelethus accepted this revision. Szelethus added a comment. Herald added a subscriber: nullptr.cpp. This is amazing. We longed for a sensible implementation for this for a long time. Really liking the unit tests as well! There are a number of inlines you didn't mark as done but seem to have ad

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

martong accepted this revision. martong added a comment. Still looks good to me! Thanks for handling the pragma cases! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93222/new/ https://reviews.llvm.org/D93222 ___ cfe-commits mailing list cfe-c

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

steakhal updated this revision to Diff 319011. steakhal added a comment. Ignore `_Pragma` macro expansions, also ignore those during lexing. Added a unit-test to demonstrate that we don't crash and these expansions are not recorded. Fix typo in `MacroExpansionContext.cpp` header comment. CHANG

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

steakhal updated this revision to Diff 318480. steakhal marked 2 inline comments as done. steakhal retitled this revision from "[RFC][analyzer] Introduce MacroExpansionContext to libAnalysis" to "[analyzer] Introduce MacroExpansionContext to libAnalysis". steakhal edited the summary of this revis