This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0999408aea79: [clangd] Add error handling (elog) in code
completion. (authored by adamcz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:193
+} else {
+ elog("Code completion header path manipulation failed {0}",
+ H
adamcz added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:193
+} else {
+ elog("Code completion header path manipulation failed {0}",
+ HeaderFile.takeError());
sammccall wrote:
> I think this is too noisy.
adamcz updated this revision to Diff 312206.
adamcz marked an inline comment as done.
adamcz added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93220/new/
https://reviews.llvm.org/D93220
Files:
clang-tools-extra/clan
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:193
+} else {
+ elog("Code completion header path manipulation failed {0}",
+ HeaderFile.takeError());
I think this is too noisy.
We can hit thi
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:187-188
+ if (auto Header = headerToInsertIfAllowed(Opts)) {
+auto HeaderFile = toHeaderFile(*Header, FileName);
+if (HeaderFile) {
if (auto Spelled =
---
adamcz created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
adamcz requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D93220
Fil
