[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62b4a69969c3: [clangd] Use enumMember instead of enumConstant (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

njames93 updated this revision to Diff 311215. njames93 marked an inline comment as done. njames93 added a comment. Remove changes to internal infrastructure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93113/new/ https://reviews.llvm.org/D93113

[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

njames93 added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:51 Enum, - EnumConstant, + EnumMember, Typedef, sammccall wrote: > `HighlightingKind` is an internal enum that doesn't match LSP naming, so no > need for changes

[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

sammccall added a comment. Thanks! Most of the changes in this patch are to the internal infrastructure, which predates LSP semanticTokens and doesn't need to have names that match (in many cases the names don't closely match C++ convention). I think only the `toSemanticTokenType` change is need

[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

njames93 created this revision. njames93 added reviewers: sammccall, hokein. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. We should be using enumMem