[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko updated this revision to Diff 317805. vsavchenko added a comment. Herald added a subscriber: mgorny. Squash all three commits, introduce new attribute and add documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93110/new/ https:

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

aaron.ballman added a comment. In D93110#2460375 , @vsavchenko wrote: > In D93110#2458613 , @aaron.ballman > wrote: > >> Have you explored how this attribute will work with clang frontend >> diagnostics or clang-t

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko added a comment. In D93110#2458613 , @aaron.ballman wrote: > Have you explored how this attribute will work with clang frontend > diagnostics or clang-tidy diagnostics? Actually, this attribute is not used anywhere in the codebase (even in `

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2366 let Args = [VariadicStringArgument<"DiagnosticIdentifiers">]; let Documentation = [SuppressDocs]; } aaron.ballman wrote: > The documentation will need to be updated for th

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

aaron.ballman added a comment. In D93110#2448587 , @vsavchenko wrote: > Right now, I reused existing `suppress` attribute. However I did it in a > rather unconventional manner. I allowed 0 arguments in one spelling and >1 > in another, which seems odd.

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2897 + ASTContext &AC) { + PathDiagnosticLocation Location = BR.getLocation(); + What will this location return?

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2907 +// start with it. +llvm::SmallVector Stack{DynTypedNode::create(*BugStmt)}; + jkorous wrote: > Since IIUC a node can have multiple parents - does that mean w

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

jkorous added a comment. Thanks for working on this! Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2907 +// start with it. +llvm::SmallVector Stack{DynTypedNode::create(*BugStmt)}; + Since IIUC a node can have multiple parents - does that me

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko added a comment. Right now, I reused existing `suppress` attribute. However I did it in a rather unconventional manner. I allowed 0 arguments in one spelling and >1 in another, which seems odd. I can see a couple other possible solutions here: - Choose a "keyword" that would be use

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: aaron.ballman. vsavchenko requested review of this revision. Herald ad