[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

2020-12-17 Thread Sean Young via Phabricator via cfe-commits
seanyoung added a comment. Patch submitted https://lore.kernel.org/bpf/20201217150102.ga13...@gofer.mess.org/T/#u Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93103/new/ https://reviews.llvm.org/D93103 ___

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

2020-12-16 Thread Sean Young via Phabricator via cfe-commits
seanyoung added a comment. Ok, I'll do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93103/new/ https://reviews.llvm.org/D93103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

2020-12-16 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. We could enable ExtIntType in bpf backend. But we need some kernel changes related to BTF to accommodate the new types. Currently, the kernel uapi file (linux/include/uapi/linux/btf.h) defines #define BTF_INT_BITS(VAL) ((VAL) & 0x00ff) which means the

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

2020-12-16 Thread Sean Young via Phabricator via cfe-commits
seanyoung updated this revision to Diff 312172. seanyoung added a comment. Add tests cases for _ExtInt on BPF. This makes the _ExtInt testing equivalent to the testing on every platform except x86-64. The use-case is to use _ExtInt on BPF when targeting Solana BPF smart contracts. I am writing

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

2020-12-15 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast requested changes to this revision. ast added a comment. This revision now requires changes to proceed. What's a use case? The test is necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93103/new/ https://reviews.llvm.org/D93103

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

2020-12-15 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. From the CFE's perspective, this is all that should be needed. Is there a BPF code-owner who can test it and see if it is acceptable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93103/new/ https://reviews.llvm.org/D9

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

2020-12-11 Thread Sean Young via Phabricator via cfe-commits
seanyoung created this revision. seanyoung added reviewers: erichkeane, jtmott-intel. seanyoung added a project: clang. seanyoung requested review of this revision. Herald added a subscriber: cfe-commits. I need to use _ExtInt on the BPF target. Simply switching it on seems to work fine. I'm a n