[PATCH] D93023: Replace deprecated %T in 2 tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG60bed4ab57d5: Replace deprecated %T in 2 tests. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93023/new/ https://reviews.llvm.org/D9302

[PATCH] D93023: Replace deprecated %T in 2 tests.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93023/new/ https://reviews.llvm.org/D93023 ___ cfe-commits mailing list cfe-commits@

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh updated this revision to Diff 322970. abidh added a comment. Changes in this version. 1. Added an explicit --sysroot argument. 2. Shortened "testroot-riscv{len}-baremetal-nogcc" string As pointed out by @MaskRay that some tests were failing when gcc-10-riscv64-linux-gnu was installed. Th

[PATCH] D93023: Replace deprecated %T in 2 tests.

MaskRay added a comment. Ping @abidh Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93023/new/ https://reviews.llvm.org/D93023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D93023: Replace deprecated %T in 2 tests.

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93023/new/ https://reviews.llvm.org/D93023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh added a comment. It seems that testcase I added has brought to surface a hidden issue. If you look at the end of Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes, it adds sysroot/usr to the Prefixes. If the sysroot is empty, this will end up using the toolchain that you installed

[PATCH] D93023: Replace deprecated %T in 2 tests.

MaskRay added a comment. My build directory is `/tmp/RelA`. After `sudo apt install gcc-10-riscv64-linux-gnu`, % /tmp/RelA/bin/llvm-lit -vv riscv32-toolchain-extra.c ... Exit Code: 1 Command Output (stderr): -- /home/ray/llvm/clang/test/Driver/riscv32-toolchain-extra.c:28:34: erro

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh added a comment. In D93023#2446757 , @MaskRay wrote: > If you do this, `testroot-riscv64-baremetal-nogcc/` is probably also not > useful (or you can replace it with a shorter string`. > > Can you fix the tests when gcc-riscv64-linux-gnu is installed

[PATCH] D93023: Replace deprecated %T in 2 tests.

MaskRay added a comment. If you do this, `testroot-riscv64-baremetal-nogcc/` is probably also not useful (or you can replace it with a shorter string`. Can you fix the tests when gcc-riscv64-linux-gnu is installed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh created this revision. abidh added a reviewer: MaskRay. abidh added a project: clang. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD,