dexonsmith planned changes to this revision.
dexonsmith added a comment.
Given that 5de00f3b56805c7e980f049ceb3f166f8c69cec0 updates the return value of
`FileEntry::getDir` as a (self-described) hack, and `FileEntryRef::getDir`
won't be similarly updated, it's somewhat reasonable that this would
dexonsmith reopened this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
Reopening for now, although I haven't updated the patch yet, or quite tracked
down the issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
dexonsmith added a comment.
There were also two Windows bots that emailed me yesterday afternoon, I just
missed them somehow :/.
- http://lab.llvm.org:8011/#/builders/119/builds/1381 (llvm-clang-win-x-aarch64)
- http://lab.llvm.org:8011/#/builders/60/builds/1175 (llvm-clang-win-x-armv7l)
FTR, t
Thanks for reverting; sorry I missed your email.
> On 2020 Dec 14, at 19:27, Nico Weber via Phabricator
> wrote:
>
> thakis added a comment.
>
> The revert helped, check-clang is no longer failing on Windows.
>
>
> Repository:
> rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
> htt
thakis added a comment.
The revert helped, check-clang is no longer failing on Windows.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92975/new/
https://reviews.llvm.org/D92975
___
cfe-commits mailing li
thakis added a comment.
Reverted in 7799ef7121aa7d59f4bd95cdf70035de724ead6f for now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92975/new/
https://reviews.llvm.org/D92975
___
cfe-commits mailing list
thakis added a comment.
One of the changes in
https://github.com/llvm/llvm-project/compare/6af2c4ca9bd...2733a5a5b44 broke
check-clang on windows. This change looks the most likely to me. Can you take a
look?
http://45.33.8.238/win/29852/step_7.txt
Repository:
rG LLVM Github Monorepo
CHAN
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa40db5502b25: Lex: Migrate HeaderSearch::LoadedModuleMaps to
FileEntryRef (authored by dexonsmith).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92975/new/
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92975/new/
https://reviews.llvm.org/D92975
___
cfe-commits mailing list
cf
dexonsmith updated this revision to Diff 310713.
dexonsmith added a comment.
I must have just been building `clangLex` before, since I missed (until now)
updating the other API users.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92975/new/
https://reviews.llvm.org/D92975
Files:
cla
dexonsmith created this revision.
dexonsmith added reviewers: arphaman, jansvoboda11.
Herald added a subscriber: ributzka.
dexonsmith requested review of this revision.
Herald added a project: clang.
Migrate `HeaderSearch::LoadedModuleMaps` and a number of APIs over to
`FileEntryRef`. This should
11 matches
Mail list logo
