gandhi21299 added a comment.
Perhaps, a description could be added to this patch before committing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92956/new/
https://reviews.llvm.org/D92956
___
cfe-commit
gandhi21299 added a comment.
Herald added a project: All.
@Quuxplusone I can commit this patch on behalf of @fanfuqiang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92956/new/
https://reviews.llvm.org/D92956
_
Quuxplusone added a comment.
What ever happened to this patch? @fanfuqiang, are you still around to rebase
this? Do you need someone to commit it for you?
(Not that I'm saying I think it's perfect as is — I haven't looked and don't
know the code that well — but just wondering what kept this from
gandhi21299 accepted this revision.
gandhi21299 added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the bug fix!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92956/new/
https://reviews.llvm.org/D92956
__
gandhi21299 added a comment.
I tried to implement a fix by using the `hasCopyAssignmentWithConstParam()`
method (instead of `hasNonTrivialCopyConstructor()`), the same test fails.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92956/new/
https://re
fanfuqiang updated this revision to Diff 310865.
fanfuqiang marked 2 inline comments as done.
fanfuqiang added a comment.
update testcase take advise of reviewers.
fix conflict testcase fail, less warnning only for hasNonTrivialCopyConstructor
.
Repository:
rG LLVM Github Monorepo
CHANGES SI
