[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c8b8031800: [openmp] Remove clause from OMPKinds.def and use OMP.td info (authored by clementval). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

jdoerfert accepted this revision. jdoerfert added a comment. LGTM still Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://reviews.llvm.org/D92955 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval added a comment. Ping since there was a phab email delivery problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://reviews.llvm.org/D92955 ___ cfe-commits mailing list cfe-c

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval updated this revision to Diff 310980. clementval added a comment. Herald added a subscriber: mgorny. Fix -Werror=covered-switch-default problems + rename OMP.cpp.inc to OMP.inc since the .cpp does not make sense anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval added a comment. In D92955#2445815 , @thakis wrote: > And a less philosophical comment: This causes a bunch of > Wcovered-switch-default warnings: > > ../../clang/include/clang/AST/OpenMPClause.h::5: warning: default label > in switch whic

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

thakis added a comment. And a less philosophical comment: This causes a bunch of Wcovered-switch-default warnings: ../../clang/include/clang/AST/OpenMPClause.h::5: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default] ../../clang/include/clang/AST/R

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

thakis added inline comments. Comment at: clang/include/clang/AST/ASTTypeTraits.h:152 +#define CLAUSE_CLASS(Enum, Str, Class) NKI_##Class, +#include "llvm/Frontend/OpenMP/OMP.cpp.inc" NKI_NumberOfKinds Now we're even including the `cpp.inc` file in .h files.

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b2847216b4: [openmp] Remove clause from OMPKinds.def and use OMP.td info (authored by clementval). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. (I missed the part that we duplicated the information so far) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://revi

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval added a comment. In D92955#2443313 , @jdoerfert wrote: > I like this a lot. We might even look into generating the clang OpenMPClause > classes via TableGen later, thanks a lot. > > There is a file missing, right? The list of actual clauses. T

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

jdoerfert added a comment. I like this a lot. We might even look into generating the clang OpenMPClause classes via TableGen later, thanks a lot. There is a file missing, right? The list of actual clauses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval updated this revision to Diff 310589. clementval added a comment. Remove useless define macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://reviews.llvm.org/D92955 Files: clang/include/clang/AST/ASTFwd.h clang/inc

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval created this revision. clementval added reviewers: jdoerfert, jdenny, kiranchandramohan. Herald added subscribers: jfb, arphaman, guansong, yaxunl. clementval requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, L