This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9c4cddb53a7b: [Clang] Add vcmla and rotated variants for Arm
ACLE. (authored by fhahn).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
That's a nice improvement. Still LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92930/new/
https://reviews.llvm.org/D92930
_
fhahn updated this revision to Diff 310799.
fhahn added a comment.
Loop over rotation variants.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92930/new/
https://reviews.llvm.org/D92930
Files:
clang/include/clang/Basic/arm_neon.td
clang/lib/Cod
fhahn added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5237
NEONMAP1(vcaddq_rot90_v, arm_neon_vcadd_rot90, Add1ArgType),
+ NEONMAP1(vcaddq_rot90_v, arm_neon_vcadd_rot90, Add1ArgType),
NEONMAP1(vcage_v, arm_neon_vacge, 0),
t.p.northover wr
fhahn updated this revision to Diff 310632.
fhahn added a comment.
Updated to use new VCMLA_ROTS multiclass to define rotated variants.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92930/new/
https://reviews.llvm.org/D92930
Files:
clang/include
t.p.northover added a comment.
Looks fine to me except for one weird quirk that I don't think should be there.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5237
NEONMAP1(vcaddq_rot90_v, arm_neon_vcadd_rot90, Add1ArgType),
+ NEONMAP1(vcaddq_rot90_v, arm_neon_vcadd_rot90, Add1
fhahn created this revision.
fhahn added reviewers: SjoerdMeijer, dmgreen, t.p.northover.
Herald added a subscriber: kristof.beyls.
fhahn requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch adds vcmla and the rotated variants as defi
