[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism updated this revision to Diff 311360. swamulism added a comment. Update comment strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92897/new/ https://reviews.llvm.org/D92897 Files: clang/test/CodeGen/new-pass-manager-opt-bisect.c

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism updated this revision to Diff 311358. swamulism marked 5 inline comments as done. swamulism added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92897/new/ https://reviews.llvm.org/D92897 Files: clang/test/Co

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

aeubanks added inline comments. Comment at: llvm/include/llvm/IR/OptBisect.h:58 + /// Checks the bisect limit to determine if the specified pass should run. + /// This calls checkPass + bool shouldRunPass(const Pass *P, StringRef IRDescription) override; ==

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism added a comment. Thank you for the comments and code review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92897/new/ https://reviews.llvm.org/D92897 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism updated this revision to Diff 311357. swamulism added a comment. Herald added subscribers: dexonsmith, hiraditya. Updating to set npm OptBisect to use global singleton OptBisect instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92897/n

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

aeubanks added a comment. Oh and in the description > This means that when using OptBisect under the NPM it runs twice when it > should only run once. doesn't really make sense. I'd say something like > e.g. -opt-bisect-limit=1 will run both the first optional optimization pass > and the firs

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

aeubanks added a comment. Thanks for looking into this! Can you upload the diff with full context (e.g. use `diff -U ` or use arcanist to upload)? Comment at: clang/lib/CodeGen/BackendUtil.cpp:1153 + // Sets legacy pass manager OptBisect to the same one as npm so passes

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism created this revision. swamulism added a reviewer: aeubanks. swamulism requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently there is an issue where the legacy pass manager uses a different OptBisect counter