This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdfac97d55769: [clangd] Validate clang-tidy Checks in clangd
config. (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
njames93 updated this revision to Diff 311948.
njames93 marked 2 inline comments as done.
njames93 added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92874/new/
https://reviews.llvm.org/D92874
Files:
clang-tools-extr
njames93 marked 4 inline comments as done.
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:58
+ assert(!Check.contains('*') && "isRegisteredCheck doesn't support globs");
+ assert(Check.trim().size() == Check.size() &&
+ "Check has
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:53
namespace clang {
+namespace tidy {
+/// Returns if a clang tidy \p Check has been registered.
nit: if this is in the clangd code, it should be in the clangd namespace
(i
njames93 updated this revision to Diff 311926.
njames93 added a comment.
Address some comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92874/new/
https://reviews.llvm.org/D92874
Files:
clang-tools-extra/clangd/ConfigCompile.cpp
clang-too
njames93 marked 2 inline comments as done.
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:26
+#include "../clang-tidy/ClangTidyModuleRegistry.h"
#include "CompileCommands.h"
sammccall wrote:
> This is a pretty weird plac
sammccall added a comment.
Thanks! Just some organization nits.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:26
+#include "../clang-tidy/ClangTidyModuleRegistry.h"
#include "CompileCommands.h"
This is a pretty weird place to depend on clang-tidy.
C
njames93 updated this revision to Diff 311094.
njames93 added a comment.
Dont check for globs coverage instead use a fast set based approach that only
matches tidy checks exactly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92874/new/
https://re
sammccall added a comment.
Thanks for doing this!
I wonder a simpler version would reach the 80/20 point... if we were to
validate only that entries *without wildcards* matched a check name, I think
we'd catch most of the typos, and it'd just be a simple set lookup.
(`bugprone-*` is quadraticall
njames93 updated this revision to Diff 310352.
njames93 added a comment.
Made GlobList::specifies const.
Made check validation function static and only taking a StringRef. This will
make it easier to refactor out at a later date if this functionality wants to
be used elsewhere.
Repository:
r
njames93 created this revision.
njames93 added reviewers: sammccall, kadircet.
Herald added subscribers: usaxena95, arphaman.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Add instrumentation in ConfigCompi
11 matches
Mail list logo
