Re: [PATCH] D9286: Insert override at the same line as the end of the function declaration

2015-08-19 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Looks good. Thanks for the fix! Repository: rL LLVM http://reviews.llvm.org/D9286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9286: Insert override at the same line as the end of the function declaration

2015-08-18 Thread Ehsan Akhgari via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245401: Insert override at the same line as the end of the function declaration (authored by ehsan). Changed prior to commit: http://reviews.llvm.org/D9286?vs=24449&id=32492#toc Repository: rL LLVM

Re: [PATCH] D9286: Insert override at the same line as the end of the function declaration

2015-08-18 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D9286#224691, @ehsan wrote: > I should land this, but let's wait to see if we want > http://reviews.llvm.org/D9285 or not, since this patch is built on top of it. > If not, I can rebase it on top of master as well. We don't want http://revie

Re: [PATCH] D9286: Insert override at the same line as the end of the function declaration

2015-08-14 Thread Ehsan Akhgari via cfe-commits
ehsan added a comment. I should land this, but let's wait to see if we want http://reviews.llvm.org/D9285 or not, since this patch is built on top of it. If not, I can rebase it on top of master as well. http://reviews.llvm.org/D9286 ___ cfe-comm

Re: [PATCH] D9286: Insert override at the same line as the end of the function declaration

2015-08-14 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. What's the status of this patch? http://reviews.llvm.org/D9286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits