[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc28b18af1962: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases (authored by melver). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver updated this revision to Diff 311157. melver added a comment. Check aliases exist in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92846/new/ https://reviews.llvm.org/D92846 Files: clang/test/CodeGen/asan-globals-alias.cpp llvm/lib

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/asan-globals-alias.cpp:30 +// KASAN: @aliased_global_2{{.*}} global i32 +// KASAN: @joydev_ids{{.*}} global [1 x {{.*}}i64 1234 }], align 16 melver wrote: > nickdesaulniers wrote: > > Do we w

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver added inline comments. Comment at: clang/test/CodeGen/asan-globals-alias.cpp:30 +// KASAN: @aliased_global_2{{.*}} global i32 +// KASAN: @joydev_ids{{.*}} global [1 x {{.*}}i64 1234 }], align 16 nickdesaulniers wrote: > Do we want to add checks for the a

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Thanks for the patch. Comment at: clang/test/CodeGen/asan-globals-alias.cpp:30 +// KASAN: @aliased_global_2{{.*}} global i32 +// KASAN: @joydev_ids{{.*}} global [1 x {{.*}}i64 1234 }], align 16 -

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver added a comment. In D92846#2442447 , @dvyukov wrote: > The code looks reasonable to me. I see it only affects kernel, so assuming > you booted kernel, we should be fine. > I can rubber-stamp it, but if you want more meaningful review, please wait

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

dvyukov accepted this revision. dvyukov added a comment. This revision is now accepted and ready to land. The code looks reasonable to me. I see it only affects kernel, so assuming you booted kernel, we should be fine. I can rubber-stamp it, but if you want more meaningful review, please wait for

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver updated this revision to Diff 310495. melver added a comment. Revert unnecessary reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92846/new/ https://reviews.llvm.org/D92846 Files: clang/test/CodeGen/asan-globals-alias.cpp llvm/lib

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver updated this revision to Diff 310494. melver added a comment. Style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92846/new/ https://reviews.llvm.org/D92846 Files: clang/test/CodeGen/asan-globals-alias.cpp llvm/lib/Transforms/Instrument

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver added a comment. In D92846#2440118 , @dvyukov wrote: > Have you checked if there is already a function that does this? Frequently > there is :) > Some functions that look similar based on names: > stripPointerCasts > stripPointerCastsAndOffsets > s

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver updated this revision to Diff 310492. melver added a comment. Simplify using stripPointerCastsAndAliases() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92846/new/ https://reviews.llvm.org/D92846 Files: clang/test/CodeGen/asan-globals-ali

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver updated this revision to Diff 310488. melver added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92846/new/ https://reviews.llvm.org/D92846 Files: