This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6baa9769ed57: [clang][cli] Add flexible TableGen multiclass
for boolean options (authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
C
jansvoboda11 added a comment.
I was, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92775/new/
https://reviews.llvm.org/D92775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
dexonsmith accepted this revision.
dexonsmith added a comment.
(LGTM, in case my conditional approval earlier wasn't clear...)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92775/new/
https://reviews.llvm.org/D92775
___
jansvoboda11 updated this revision to Diff 311208.
jansvoboda11 added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92775/new/
https://reviews.llvm.org/D92775
Files:
clang/include/clang/Driver/Options.td
clang/lib/Frontend/Co
jansvoboda11 added inline comments.
Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:226
ASSERT_THAT(GeneratedArgs,
- Contains(StrEq("-fno-experimental-new-pass-manager")));
+ Not(Contains(StrEq("-fno-experimental-new-pass-manager";
jansvoboda11 updated this revision to Diff 310249.
jansvoboda11 added a comment.
Split out change to "always emit" behavior of
`-f[no-]experimental-new-pass-manager` and rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92775/new/
https://revi
Bigcheese added inline comments.
Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:226
ASSERT_THAT(GeneratedArgs,
- Contains(StrEq("-fno-experimental-new-pass-manager")));
+ Not(Contains(StrEq("-fno-experimental-new-pass-manager";
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM if you undo the change to lose support for AlwaysEmit (happy to consider
in a separate patch if it’s the right thing to do though).
Comment at: clang/include/cl
jansvoboda11 added a comment.
That's great to hear, thanks.
Comment at: clang/include/clang/Driver/Options.td:371
+ // TODO: Assert that the flags have different value.
+ // TODO: Assert that only one of the flags can be implied.
+
Does TableGen support some
jansvoboda11 updated this revision to Diff 310135.
jansvoboda11 added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92775/new/
https://reviews.llvm.org/D92775
Files:
clang/include/clang/Driver/Options.td
clang/lib/Frontend/C
dexonsmith added a comment.
> Not 100% sure the benefits are worth the added complexity.
I think this is worth it. Names seem pretty clear to me. All around, this seems
a lot more clear to me than the approach you had in the CodeGenOptions patch.
Comment at: clang/unittests/F
jansvoboda11 created this revision.
jansvoboda11 added reviewers: dexonsmith, Bigcheese.
Herald added a subscriber: dang.
jansvoboda11 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This introduces more flexible multiclas
12 matches
Mail list logo
