[PATCH] D92720: [HIP] unbundle bundled preprocessor output

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f14b80803a4: [HIP] unbundle bundled preprocessor output (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

yaxunl marked an inline comment as done. yaxunl added a comment. In D92720#2453277 , @tra wrote: > In D92720#2448890 , @yaxunl wrote: > >> Output of `-E` for HIP combined host/device compilation is a plain text. It

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D92720#2448890 , @yaxunl wrote: > Output of `-E` for HIP combined host/device compilation is a plain text. It > has C++ comments inserted between preproce

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

yaxunl marked an inline comment as done. yaxunl added a comment. In D92720#2437621 , @tra wrote: > `-E` by default prints preprocessed output to stdout. CUDA will print > preprocessed output from all subcompilations. What does HIP do in this case? > Prin

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

yaxunl updated this revision to Diff 311225. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92720/new/ https://reviews.llvm.org/D92720 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/hip-unbundle-preproc.hip Index: clang/tes

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

tra added a comment. `-E` by default prints preprocessed output to stdout. CUDA will print preprocessed output from all subcompilations. What does HIP do in this case? Printing out the bundle is probably not what the user will expect. IMO preprocessed output is frequently used as a debugging too

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. There is a use case that users want to emit preprocessor output as file and compile the preprocessor output later with `-x hip-cpp-output`. Clang emits bundled preprocessor output when users comp