Yep, thanks. This uncovered an existing error, so rather than reverting the
whole thing I've disabled the assert on windows while I fix
it. f1357264b8e3070bef5bb4ff35ececa4d6c76108
On Mon, Dec 7, 2020 at 12:22 PM Nico Weber via Phabricator <
revi...@reviews.llvm.org> wrote:
> thakis added a comme
thakis added a comment.
Looks like this breaks tests on windows: http://45.33.8.238/win/29315/step_9.txt
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92704/new/
https://reviews.llvm.org/D92704
___
cfe-c
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
sammccall marked 2 inline comments as done.
Closed by commit rGfed9af29c2b5: [clangd] Publish config file errors over LSP
(authored by sammccall).
Changed prior to com
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The pre-merging bot seems to be failed on windows:
https://reviews.llvm.org/harbormaster/unit/view/215879/.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:833
+ llvm
sammccall updated this revision to Diff 309688.
sammccall added a comment.
Handle diagnostics without a filename
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92704/new/
https://reviews.llvm.org/D92704
Files:
clang-tools-extra/clangd/ClangdServe
sammccall created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
We don't act as a language server for these files (e.g. don't get ope
