This revision was automatically updated to reflect the committed changes.
Closed by commit rGa1cb9cbf5c49: Add ability to load a FixedCompilationDatabase
from a buffer. (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92640/new/
usaxena95 accepted this revision.
usaxena95 added a comment.
This revision is now accepted and ready to land.
Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92640/new/
https://reviews.llvm.org/D92640
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang/include/clang/Tooling/CompilationDatabase.h:194
+ static std::unique_ptr
+ loadFromBuffer(StringRef Path, StringRef Data, std::string &ErrorMsg);
+
usaxena95 wrote:
>
sammccall updated this revision to Diff 309630.
sammccall marked an inline comment as done.
sammccall added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92640/new/
https://reviews.llvm.org/D92640
Files:
clang/
usaxena95 added inline comments.
Comment at: clang/include/clang/Tooling/CompilationDatabase.h:194
+ static std::unique_ptr
+ loadFromBuffer(StringRef Path, StringRef Data, std::string &ErrorMsg);
+
`Path` is not meaningful for load from buffer. May be change n
sammccall created this revision.
sammccall added a reviewer: usaxena95.
Herald added a subscriber: kadircet.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added a project: clang.
Previously, loading one from a file meant allowing the libr
