[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97bcafa28deb: [analyzer] Add control flow arrows to the analyzer's HTML reports (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHA

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. In D92639#2786648 , @ASDenysPetrov wrote: > OK, then. Let's land it! Can you please take a look at D92928 as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. OK, then. Let's land it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 ___

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. In D92639#2785057 , @ASDenysPetrov wrote: > @vsavchenko How about this? Yep, thanks for reminding! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko updated this revision to Diff 348479. vsavchenko added a comment. Fix IE issue and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 Files: clang/include/clang/Analysis/PathDiagnostic.h

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

ASDenysPetrov added a comment. Herald added a subscriber: manas. @vsavchenko How about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 ___ cfe-commits maili

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

ASDenysPetrov added a comment. In D92639#2717134 , @vsavchenko wrote: > In D92639#2716973 , @ASDenysPetrov > wrote: > >> @vsavchenko >> I make some tests and fixes. Please, consider. > > OMG, that's so awesome! Th

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. In D92639#2716973 , @ASDenysPetrov wrote: > @vsavchenko > I make some tests and fixes. Please, consider. OMG, that's so awesome! Thank you so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

ASDenysPetrov added a comment. @vsavchenko I make some tests and fixes. Please, consider. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:458 } if (event.key == "S") { var checked = document.getElementsByName("showCounterexample")[0].checked; -

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. Herald added a subscriber: nullptr.cpp. In D92639#2505163 , @ASDenysPetrov wrote: > @vsavchenko > >> F14534708: report-6ea17d.html > > I checked it in IE. It doesn't draw arrows. Investigate

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

ASDenysPetrov added a comment. @vsavchenko > F14534708: report-6ea17d.html I checked it in IE. It doesn't draw arrows. Investigate this, please. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:147 +bool isArrowPiece(const Pat

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko updated this revision to Diff 310481. vsavchenko added a comment. Replace let with const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 Files: clang/include/clang/Analysis/PathDiagnostic.h c

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko updated this revision to Diff 309497. vsavchenko added a comment. Fix incorrect comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 Files: clang/include/clang/Analysis/PathDiagnostic.h cl

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. In D92639#2433303 , @OikawaKirie wrote: > It is really a good idea! Thanks 😊 > The operations that would not leave an event in the report are now clearly > printed. > > But there are three arrows that confuse me in the exampl

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

OikawaKirie added a comment. It is really a good idea! The operations that would not leave an event in the report are now clearly printed. But there are three arrows that confuse me in the example report: the assignment `x = 0` (x -> 0 -> x), the function call `dereference(x)` (x -> dereferen

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. Here is how it looks for that test file: F14534708: report-6ea17d.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 __

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, Szelethus, steakhal, martong, ASDenysPetrov. Herald added subscribers: Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald