[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

dexonsmith added a comment. Thanks for the reviews! Pushed 2878e965af27ce037378a4f0409e89039108c09f . Comment at: clang/include/clang/Basic/DirectoryEntry.h:104 + bool isSpecialDenseMapKey() const { +ret

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

This revision was automatically updated to reflect the committed changes. dexonsmith marked an inline comment as done. Closed by commit rG2878e965af27: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef (authored by dexonsmith). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DirectoryEntry.h:104 + bool isSpecialDenseMapKey() const { +return ME == llvm::DenseMapInfo::getEmptyKey() || + ME == llvm::DenseMapInfo::getTombstoneKey(); jansvoboda11 wrote:

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Left a couple of nits and a question, but LGTM overall. Comment at: clang/include/clang/Basic/DirectoryEntry.h:104 + bool isSpecialDenseMapKey() const { +ret

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Allow hashing FileEntryRef and DirectoryEntryRef via `hash_value`, and use that to i