This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGacd4950d4f1e: [FPEnv] Correct constrained metadata in
fp16-ops-strict.c (authored by kpn).
Changed prior to commit:
https://reviews.llvm.org/D9259
mibintc accepted this revision.
mibintc added a comment.
This revision is now accepted and ready to land.
Thanks for the additional info @kpn
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92596/new/
https://reviews.llvm.org/D92596
kpn added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3006
+ CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, OpInfo.FPFeatures);
SourceLocation Loc = E->getExprLoc();
mibintc wrote:
> kpn wrote:
> > mibintc wrote:
> > > What's the rule
mibintc added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3006
+ CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, OpInfo.FPFeatures);
SourceLocation Loc = E->getExprLoc();
kpn wrote:
> mibintc wrote:
> > What's the rule to follow about w
kpn added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2992
// floating point environment in the loop.
+//XXX true?
llvm::BasicBlock *startBB = Builder.GetInsertBlock();
mibintc wrote:
> did you mean to leave this here? (blame shows t
mibintc added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2992
// floating point environment in the loop.
+//XXX true?
llvm::BasicBlock *startBB = Builder.GetInsertBlock();
did you mean to leave this here? (blame shows the fixme comm
kpn created this revision.
kpn added reviewers: sepavloff, mibintc.
kpn added a project: clang.
kpn requested review of this revision.
Herald added a subscriber: cfe-commits.
This test shows we're in some cases not getting strictfp information from the
AST. Correct that.
Repository:
rG LLVM G
