This revision was automatically updated to reflect the committed changes.
Closed by commit rG245218bb3555: Basic: Support named pipes natively in
SourceManager and FileManager (authored by dexonsmith).
Changed prior to commit:
https://reviews.llvm.org/D92531?vs=311004&id=313618#toc
Repository:
dexonsmith marked an inline comment as done.
dexonsmith added a comment.
Thanks for the review!
Comment at: clang/lib/Basic/SourceManager.cpp:167
+ // (which may have come from a stat cache).
+ if (ContentsEntry->isNamedPipe()) {
+// Check the buffer size directly if this
arphaman added a comment.
Left one minor suggestion , but LGTM otherwise
Comment at: clang/lib/Basic/SourceManager.cpp:167
+ // (which may have come from a stat cache).
+ if (ContentsEntry->isNamedPipe()) {
+// Check the buffer size directly if this is a named pipe.
-
dexonsmith marked an inline comment as done.
dexonsmith added inline comments.
Comment at: clang/lib/Basic/SourceManager.cpp:567
+ if (IR.ContentsEntry->isNamedPipe())
+(void)IR.getBufferOrNone(Diag, getFileManager(), SourceLocation());
+
jansvoboda11 wrote:
dexonsmith updated this revision to Diff 311004.
dexonsmith retitled this revision from "Reapply "Frontend: Sink named pipe
logic from CompilerInstance down to FileManager"" to "Basic: Support named
pipes natively in SourceManager".
dexonsmith edited the summary of this revision.
dexonsmith added
