This revision was automatically updated to reflect the committed changes.
Closed by commit rGd8949a8ad3ca: [hip] Fix host object creation from fatbin
(authored by hliao).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92418/new/
https://reviews.llvm.
ashi1 added a comment.
Looks good to me, were you able to run staging on this patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92418/new/
https://reviews.llvm.org/D92418
___
cfe-commits mailing list
hliao added a comment.
Even there's no functionality change, the original one breaks the kernel
extraction script, which is designed to find the `.hip_fatbin` section. That
internal tool is still required to extract kernels from objects generated from
RDC linking.
Repository:
rG LLVM Github
hliao created this revision.
hliao added reviewers: yaxunl, ashi1.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
hliao requested review of this revision.
- `__hip_fatbin` should a symbol in `.hip_fatbin` section.
Repository:
rG LLVM Github Monorepo
https://reviews.llv