[PATCH] D92357: clang/darwin: Don't use response files with ld64

This revision was automatically updated to reflect the committed changes. Closed by commit rG68f2ff59d114: clang/darwin: Don't use response files with ld64 (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D92357: clang/darwin: Don't use response files with ld64

thakis added a comment. In D92357#2426042 , @keith wrote: > I'm a bit worried that without a repro case (outside of the missing newline) > Apple won't get around to fixing this, and in the meantime I'm wondering if > outside of the chromium build system

[PATCH] D92357: clang/darwin: Don't use response files with ld64

keith added a comment. I'm a bit worried that without a repro case (outside of the missing newline) Apple won't get around to fixing this, and in the meantime I'm wondering if outside of the chromium build system folks will experience this. I wonder if there's an acceptable alternative here suc

[PATCH] D92357: clang/darwin: Don't use response files with ld64

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis updated this revision to Diff 308684. thakis edited the summary of this revision. thakis added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 Files: clang/lib/Driver/ToolChains/Darwin.cpp Index: clang/lib/Driver/Too

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis added a comment. Extracted the darwinnew bits to D92399 . Will rebase this once that's in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 ___ cfe-commits maili

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis added a comment. In D92357#2424484 , @keith wrote: > It looks like at least in the `-Wl` case clang passes the file through > directly, Right, that's my point: We see crashes around response files even if we let clang write it. > I _don't_ actua

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

keith added a comment. It looks like at least in the `-Wl` case clang passes the file through directly, so I'm not surprises that it repros there: % clang -Wl,@shell_dialogs_unittests.rsp -v Apple clang version 12.0.0 (clang-1200.0.32.27) Target: x86_64-apple-darwin19.6.0 Thread model: p

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis added a comment. In D92357#2424422 , @keith wrote: > Note in your repro case the issue is that the response file doesn't end in a > trailing newline Hm, we also see crashes if we let clang write the response file that's passed to ld64 though. (ie

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

keith added a comment. Note in your repro case the issue is that the response file doesn't end in a trailing newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 ___ cfe-commits mailing list cfe-co

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis created this revision. thakis added a reviewer: jyknight. thakis requested review of this revision. This morally reverts D82777 -- turns out that ld64 crashes with many response files, so we must stop passing them to it until the crash is fixed. On the ot