[PATCH] D92355: [clang] add a `swift_async_name` attribute

2020-12-04 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeddd1d192bca: [clang] add a `swift_async_name` attribute (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D92355?vs=309582&id=309690#toc Repository: rG LLVM Github Monorepo

[PATCH] D92355: [clang] add a `swift_async_name` attribute

2020-12-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92355/new/ https://reviews.llvm.org/D92355 ___ cfe-commits mailing list

[PATCH] D92355: [clang] add a `swift_async_name` attribute

2020-12-04 Thread Doug Gregor via Phabricator via cfe-commits
doug.gregor accepted this revision. doug.gregor added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92355/new/ https://reviews.llvm.org/D92355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D92355: [clang] add a `swift_async_name` attribute

2020-12-04 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D92355#2429117 , @aaron.ballman wrote: > There's no information in either the attribute definition in Attr.td or in > the documentation as to what subject this attribute applies to. Added a subject list to the attribute.

[PATCH] D92355: [clang] add a `swift_async_name` attribute

2020-12-04 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 309582. arphaman marked 3 inline comments as done. arphaman added a comment. Herald added a subscriber: jdoerfert. address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92355/new/ https://reviews.llvm.org/D92355 Files: clang/incl

[PATCH] D92355: [clang] add a `swift_async_name` attribute

2020-12-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. There's no information in either the attribute definition in Attr.td or in the documentation as to what subject this attribute applies to. Comment at

[PATCH] D92355: [clang] add a `swift_async_name` attribute

2020-12-02 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/AttrDocs.td:3640 +The argument is a string literal that contains the Swift name of the function or +method. The

[PATCH] D92355: [clang] add a `swift_async_name` attribute

2020-11-30 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: erik.pilkington, aaron.ballman. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. arphaman requested review of this revision. The `swift_async_name` attribute provides a name for a function/method that can be used