[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe16959c9b855: Don't delete default constructor of PathDiagnosticConsumerOptions (authored by MoritzS). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/ne

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS added a comment. Some tests were failing, I'll try to fix that and then commit the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 ___ cfe-commit

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS updated this revision to Diff 318477. MoritzS edited the summary of this revision. MoritzS added a comment. Initialize bool flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 Files: clang/inclu

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

vsavchenko accepted this revision. vsavchenko added a comment. Hi @MoritzS thanks for the cleanup! Maybe while you are on it, you can set default values as pointed by @NoQ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.ll

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS updated this revision to Diff 318463. MoritzS added a comment. Rebased onto master, run tests again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 Files: clang/include/clang/Analysis/PathDiagnost

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS updated this revision to Diff 313145. MoritzS added a comment. Rebased onto master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 Files: clang/include/clang/Analysis/PathDiagnostic.h Index: cla

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS added a comment. Another way to avoid UB in that case is to use value initialization, i.e. `PathDiagnosticConsumerOptions options{};`. Can you commit this, please? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

NoQ accepted this revision. NoQ added a reviewer: vsavchenko. NoQ added a comment. This revision is now accepted and ready to land. Aha, ok then! Thanks for cleaning this up. Maybe we should provide default initializers for `bool` flags then, so that they weren't undefined by default. ===

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS created this revision. MoritzS added a reviewer: dergachev.a. Herald added subscribers: cfe-commits, Charusso. Herald added a project: clang. MoritzS requested review of this revision. This type is used as an aggregate, i.e. it has no member functions. Starting with C++20 types with delete