[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev abandoned this revision. kbobyrev added a comment. Yeah this does indeed already work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92220/new/ https://reviews.llvm.org/D92220 ___ cfe-commits ma

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:630 )cpp", + R"cpp( +template struct Foo { static T Variable; }; hokein wrote: > hmm, looks like these two tests are already working at head (witho

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to check this patch again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92220/new/ https://reviews.llvm.org/D92220 ___ cfe-commi

[PATCH] D92220: [clangd] Add support for static fields in rename

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:630 )cpp", + R"cpp( +template struct Foo { static T Variable; }; hmm, looks like these two tests are already working at head (without the patch). R

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev updated this revision to Diff 308008. kbobyrev added a comment. Add comments and a check to ensure proper behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92220/new/ https://reviews.llvm.org/D92220 Files: clang-tools-extra/clangd

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Follow-up on D91952