[PATCH] D92198: [clangd] Log remote index connectivity status

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcdef5b5b3df: [clangd] Log remote index connectivity status (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311943. kbobyrev added a comment. Actually clean up rebase artifacts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Cl

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311942. kbobyrev added a comment. Cleanup rebase artifact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp I

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311939. kbobyrev added a comment. Cleanup includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp Index: c

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 311937. kbobyrev marked an inline comment as done. kbobyrev added a comment. Remove the race between ConnectionStatus access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D

[PATCH] D92198: [clangd] Log remote index connectivity status

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG with one fix around the atomic Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:49 +auto NewStatus = Channel->GetState(/*try_to_connect=*/false); +

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 310642. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-to

[PATCH] D92198: [clangd] Log remote index connectivity status

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:91 SPAN_ATTACH(Tracer, "Failed to parse", FailedToParse); +vlog("Remote index ({0}): {1} -> {2}", ServerAddress, toString(OldStatus), + toString(Channel->GetState(/*try_

[PATCH] D92198: [clangd] Log remote index connectivity status

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:114 assert(!ProjectRoot.empty()); +ChannelStatusWatcher = std::thread([&Channel]() { + grpc_connectivity_state Status = kbobyrev wrote: > sammccall wrote:

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 310381. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:114 assert(!ProjectRoot.empty()); +ChannelStatusWatcher = std::thread([&Channel]() { + grpc_connectivity_state Status = sammccall wrote: > The thread is a b

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 ___ cfe-comm

[PATCH] D92198: [clangd] Log remote index connectivity status

sammccall added a comment. Thanks! Hooking into the native status stuff seems much nicer! Sorry if it seems like we're going in circles here, I think we should be careful about adding background threads so want to look at an alternative too. Comment at: clang-tools-extra/clan