[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

gulfem added a comment. > Thanks! We found the issue. I think I'll revert the patch, and will reland a > fixed version. Great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 __

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

aganea added a comment. Thanks! We found the issue. I think I'll revert the patch, and will reland a fixed version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 _

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

gulfem added a comment. > @gulfem We're taking a look now. Could you please post a link to the full > build log, including the cmake flags used? This is the link to one of our failing builds: https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang-linux-arm64/b8849674814150864912/overview Here,

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

aganea added a comment. @gulfem We're taking a look now. Could you please post a link to the full build log, including the cmake flags used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

gulfem added a comment. This seems to break our `Fucshia` builds. If we cannot do a quick fix, we need to revert this patch. Please see the error message below: FAIL: Clang :: ClangScanDeps/vfsoverlay.cpp (1863 of 27822) TEST 'Clang :: ClangScanDeps/vfsoverlay.cpp' FAILED

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb26fa8c286b: [clang-scan-deps] Add support for clang-cl (authored by saudi, committed by aganea). Changed prior to commit: https://reviews.llvm.org/D92191?vs=318553&id=338330#toc Repository: rG LLVM

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. This is similar enough to the original patch I'm comfortable signing off, even though @Bigcheese hasn't had a chance to take a look. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 318553. saudi marked an inline comment as done. saudi added a comment. Applied the suggestions from the parent patch D95099 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 Fi

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

dexonsmith added a comment. In D92191#2512960 , @saudi wrote: > Removed the support for "--" command lines, it was extracted to patch D95099 > . > Applied suggested fixes. Thanks! @Bigcheese, since you reviewed the origi

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi marked an inline comment as done. saudi added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/static-analyzer-cdb.json:4-5 "directory": "DIR", - "command": "clang --analyze DIR/static-analyzer.c", - "file": "DIR/static-analyzer.c" + "command": "clang --an

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 318248. saudi edited the summary of this revision. saudi added a comment. Removed the support for "--" command lines, it was extracted to patch D95099 . Applied suggested fixes. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

dexonsmith added a comment. It would be great if you could split the `--` support out into a separate patch to commit ahead of time, but I left a couple of comments since I was taking a look. Comment at: clang/lib/Tooling/Tooling.cpp:438-440 for (StringRef Arg : Args)

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi added a comment. Ping! Would anybody have a chance to take a look at this? I'd like to submit this before the LLVM 12 branch, if possible? Thanks in advance! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 316768. saudi edited the summary of this revision. saudi added a comment. Updated the tests for clang-cl command lines: I moved the input files to end of command line, with `--`, to avoid linux-style paths conflict with clang-cl arguments. I also had to fix th

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/macm1/174/step_6.txt Ptal, and revert for now if it takes a while to fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rG640ad769110f: [clang-scan-deps] Support clang-cl (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D921

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Thanks for the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 ___ cfe-commits

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 308770. saudi added a comment. Rebase after https://reviews.llvm.org/D92330. Also, improved the detection of target obj file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 Files: clang/test/ClangScanDeps/I

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 308068. saudi added a comment. Removed `/Fo` option. `-o` is also supported by clang-cl and overrides /Fo options that are found earlier in the command line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 Fi

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

hans added a comment. Seems reasonable to me, but someone who actually knows clang-scan-deps should take a look too. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:471 +#ifdef _WIN32 +const char *NullFile = "nul"; +#else these string constan

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi created this revision. saudi added reviewers: arphaman, jkolek, Bigcheese, kousikk. saudi added a project: clang. Herald added subscribers: cfe-commits, tschuett, ormris. saudi requested review of this revision. clang-scan-deps contains some command line parsing and modifications. This patch