[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

aaron.ballman closed this revision. aaron.ballman added a comment. In D92108#2439223 , @nigelp-xmos wrote: > Many thanks for review and approval. Please could it be committed as I do not > have commit access? (I will request.) Happy to do so! I've commit

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos added a comment. Many thanks for review and approval. Please could it be committed as I do not have commit access? (I will request.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this is a good change but would point out that the diagnostic message is pretty confusing as-is. `u8"a"` is a string literal, so saying that a string literal is expected

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos updated this revision to Diff 307638. nigelp-xmos added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108 Files: clang/lib/Parse/ParseDecl.cpp clang/test/Parser/att

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos updated this revision to Diff 307636. nigelp-xmos added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108 Files: clang/lib/Parse/ParseDecl.cpp clang/test/Parser/att

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos added a comment. Alternatively, if all 1-byte-character strings are acceptable, should I remove the check that the first token is a string literal, and omit the failing test case on XCore? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nigelp-xmos requested review of this revision. Function Parser::ParseAvailabilityAttribute checks that the message string of an availability attribute is not a wide string literal. Test case c