[PATCH] D92041: Add hover info for `this` expr

2020-11-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const CXXThisExpr *CTE, const SymbolIndex *Index) { + const NamedDecl *D = CTE->getType()->getPointeeType()->

[PATCH] D92041: Add hover info for `this` expr

2020-11-25 Thread xndcn via Phabricator via cfe-commits
xndcn added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const CXXThisExpr *CTE, const SymbolIndex *Index) { + const NamedDecl *D = CTE->getType()->getPointeeType()->get

[PATCH] D92041: Add hover info for `this` expr

2020-11-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. Thanks, this sounds like a sensible idea. I got a few suggestions for the implementation though. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const CXXThisExp

[PATCH] D92041: Add hover info for `this` expr

2020-11-24 Thread xndcn via Phabricator via cfe-commits
xndcn created this revision. xndcn added reviewers: sammccall, kadircet. xndcn added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. xndcn requested review of this revision. How about add hover information for `this` expr? It