[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

This revision was automatically updated to reflect the committed changes. Closed by commit rGabfcb606c2f8: [clangd] Add support for within-file rename of complicated fields (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/n

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307834. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve another round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files:

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:132 +// instantiated. +// FIXME: Maybe a proper way of fixing this would be enhancing Clang AST +// a

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307818. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files: clang

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:134 +// although it might be a bigger effort. +const auto *FieldParent = dyn_cast(Field->getParent()) + ->getTemplateInstantiationPattern(); ---

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307327. kbobyrev added a comment. Added support for static templated fields. Ready for the review again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files: clang

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev planned changes to this revision. kbobyrev added a comment. template struct Foo { static T [[Var^iable]]; }; template <> int Foo::[[Variable^]] = 42; template <> bool Foo::[[Variable^]] = true; void foo() { int LocalInt = Foo::[[Variable^]]; bool Local

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev updated this revision to Diff 307317. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve most actionable comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/new/ https://reviews.llvm.org/D91952 Files:

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

hokein added a comment. I assume this fixes https://github.com/clangd/clangd/issues/582? can you check the static members in template classes etc? I think the AST is different. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:131 +// Clang AST does not store relev

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This was originally a part of D71880