[PATCH] D91949: [clang-format] Add BreakBeforeStructInitialization configuration

2020-11-26 Thread Anastasiia Lukianenko via Phabricator via cfe-commits
anastasiia_lukianenko added a comment. Thanks for the detailed review. After more detailed testing, I will upload a new version of the patches, which will fix configuration influence on other formatting options. Comment at: clang/lib/Format/TokenAnnotator.cpp:3492 const Fo

[PATCH] D91949: [clang-format] Add BreakBeforeStructInitialization configuration

2020-11-26 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Firstly thank you for the patch, and believe me I don't want to discourage you (as I remember my first patches), I think the rational is ok, but I think you might be laser focused on your use case and not looking at the impact on the change of the wider clang-for

[PATCH] D91949: [clang-format] Add BreakBeforeStructInitialization configuration

2020-11-26 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Ok, thank you for making the changes so its easier to review, Do you think this style should be part of the "BraceMapping" style? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 __

[PATCH] D91949: [clang-format] Add BreakBeforeStructInitialization configuration

2020-11-26 Thread Anastasiia Lukianenko via Phabricator via cfe-commits
anastasiia_lukianenko updated this revision to Diff 307797. anastasiia_lukianenko added a comment. 1. Diff was made by svn tool with full context 2. Added description in documentation 3. Added unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/

[PATCH] D91949: [clang-format] Add BreakBeforeStructInitialization configuration

2020-11-23 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Could you make you patch with a full context diff, plus we really want unit tests for all changes if you change Format.h you need to regenerate the ClangFormatStyleOptions.rst by running dump_style.py in clang/docs/tools Repository: rG LLVM Github Monorepo C