This revision was automatically updated to reflect the committed changes.
Closed by commit rG27553933a869: [clang-tidy] Add support for diagnostics with
no location (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91885/new/
htt
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:276
+ // Never ignore these.
+} else if (!Context.isCheckEnabled(Error.D
njames93 updated this revision to Diff 309521.
njames93 added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91885/new/
https://reviews.llvm.org/D91885
Files:
clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
clang-to
njames93 marked 2 inline comments as done.
njames93 added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:276
+ // Never ignore these.
+} else if (!Context.isCheckEnabled(Error.DiagnosticName) &&
+ Error.DiagLevel !
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:183
+
+ /// Adds a diagnostic to report errors in the checks configuration.
+ DiagnosticBuilder
checks -> check's
Comment at: clang-tools-extra/cla
njames93 updated this revision to Diff 306884.
njames93 added a comment.
Fix unittest failing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91885/new/
https://reviews.llvm.org/D91885
Files:
clang-tools-extra/clang-tidy/ClangTidyCheck.cpp
clan
njames93 created this revision.
njames93 added reviewers: alexfh, aaron.ballman.
Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai.
Herald added a project: clang.
njames93 requested review of this revision.
Add methods for emitting diagnostics with no location as well as a specia
