This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd1ed67037de6: [GNU ObjC] Fix a regression listing methods
twice. (authored by theraven).
Changed prior to commit:
https://reviews.llvm.org/D91874?
rjmccall added a comment.
Functionally LGTM. I don't know if 11 is still taking changes, but if it is,
you have code-owner approval.
Comment at: clang/test/CodeGenObjC/gnu-method-only-once.m:8
+// merging happened was missed in the move and so we ended up emitting two
+// cop
lanza accepted this revision.
lanza added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91874/new/
https://reviews.llvm.org/D91874
___
cf
theraven added a comment.
I'd like to get this into the 11 point release, so it would be good to have a
review...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91874/new/
https://reviews.llvm.org/D91874
___
theraven added a comment.
This was caught with the GNUstep runtime's test suite, which apparently had not
been run with anything newer than clang 8 until recently. With this patch, all
of the runtime's tests now pass again (a few others failed in 10 but appear to
have been fixed in 11 or 12).
theraven created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
theraven requested review of this revision.
Methods synthesized from declared properties were being added to the
method lists twice. This came from the change to list them in the
class's method
