This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG43267929423b: [CUDA] Another attempt to fix early inclusion
of from libstdc++ (authored by tra).
Repository:
rG LLVM Github Monorepo
CHANGE
tra updated this revision to Diff 309598.
tra added a comment.
Removed forgotten pop_macro(__DEVICE__)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91807/new/
https://reviews.llvm.org/D91807
Files:
clang/lib/Headers/cuda_wrappers/new
Index: cl
tra requested review of this revision.
tra added a comment.
@jlebar PTAL. The previous fix did not quite fix the problem. `__device__
operator new/delete` was still not defined, but the issue was not reported due
to deferred diags if the functions were not used.
Repository:
rG LLVM Github Mo
tra updated this revision to Diff 309595.
tra added a comment.
Better fix for the early inclusion of
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91807/new/
https://reviews.llvm.org/D91807
Files:
clang/lib/Headers/cuda_wrappers/new
Index: cla
tra reopened this revision.
tra added a comment.
This revision is now accepted and ready to land.
Reopening the tracker for a better fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91807/new/
https://reviews.llvm.org/D91807
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9a465057a64d: [CUDA] Unbreak CUDA compilation with
-std=c++20 (authored by tra).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
How fun. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91807/new/
https://reviews.llvm.org/D91807
_
tra created this revision.
tra added a reviewer: jlebar.
Herald added subscribers: bixia, yaxunl.
Herald added a project: clang.
tra requested review of this revision.
Standard libc++ headers in stdc++ mode include which picks up
cuda_wrappers/new before any of the CUDA macros have been defined.