kadircet added inline comments.
Herald added projects: clang-tools-extra, All.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1306
+for (const LocatedSymbol &Sym : *Overrides)
+ Impls.push_back(Sym.PreferredDeclaration);
+return Reply(std::move(
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb31486ad9717: [clangd] textDocument/implementation (LSP
layer) (authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
thanks, looks good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91721/new/
https://reviews.llvm.org/D91721
__
usaxena95 updated this revision to Diff 306969.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91721/new/
https://reviews.llvm.org/D91721
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-t
usaxena95 marked 3 inline comments as done.
usaxena95 added a comment.
> Looks like the patch is based on the old revision (pre-merging tests are
> failing), I assume you have fixed the failure tests last week?
Yes. That was fixed last week. Rebased.
Repository:
rG LLVM Github Monorepo
CHAN
hokein added a comment.
just nits.
Looks like the patch is based on the old revision (pre-merging tests are
failing), I assume you have fixed the failure tests last week?
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:615
{"workspaceSymbolProvider", tru
usaxena95 created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman.
Herald added a project: clang.
usaxena95 requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D91721
Files:
