[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

2020-11-18 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaad3ea8983a8: [clangd] Remove the trailing "." in add-using message. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91694/new/ https://

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

2020-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D91694#2402203 , @njames93 wrote: > If you are doing this may as well cover `DefineOutline` and > `RemoveUsingNamespace` - that one can do away with formatv too. good catch, thanks! Repository: rG LLVM Github Monorepo CHAN

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

2020-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 306045. hokein added a comment. Fix other code actions as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91694/new/ https://reviews.llvm.org/D91694 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsin

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

2020-11-18 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. If you are doing this may as well cover `DefineOutline` and `RemoveUsingNamespace` - that one can do away with formatv too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91694/new/ https://reviews.llvm.org/D91694 ___

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

2020-11-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: adamcz. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. to be consistent witih other code actions. Repository